Per text editeable options (size, color)

[gsantner]

Heres how an other app is doing this:

[gsantner]

If you need more information ask. This issue is an idea, and about people to start contributing to the project. It has not much information because I pasted many ideas/issues and just let them out at the same time :). If you are interested in working on this, and have questions I can give you more details on this.

Register on https://hacktoberfest.digitalocean.com/, send a PR to fix this and get your t-shirt for free (4 accepted PRs to same or different GitHub repositories needed) :). You have to mention the issue number in the commit/PR (e.g. fix #20 / about #8) Find more hacktober issues from my projects: https://github.com/search?&q=label%3Ahacktoberfest+user%3Agsantner

[aumarbello]

Interested in this issue, can you provide more details please?

[gsantner]

This should allow to edit options of textes per element, and not global. See this comment. Basically whats seen above in screenshots. First start is to rework the toolbar and integrate edit element there which reacts on pressing on a editeable element on the screen. finding out which was clicked on the image is therefore needed too

[aumarbello]

Edit elements which react on pressing on an editable element on the screen

Edit elements like what pls?
Do you suggest bring the share and save menuitems to a bottomNavBar?

Thinking of using a button to add text, prompt the user on the position - (top or bottom) and making a edit text visible, icons to the right of the edit text can be used to style the currentText and select when it's done?

[gsantner]

This is already another step :D Basically two fields do already exist, top and bottom caption. If those are working the next is to add support for adding more, and editing them. I think the most important things are font-size and the text. everything else can be put e.g. in a popup dialog. or seperate them by category, idea from other app see above. try to find out what works best

[aumarbello]

How about adding an image to the right of the edittext to style individual texts?

[gsantner]

An imagebutton? yeah, possibly. like in ?

[aumarbello]

Yeah exactly, will like to bring the edit text of the bottom text to below the image too

[gsantner]

you could go for 2 possible "spawn" locations of the editing-bar, top and bottom. Where a click on a edit element on the top 50% spawns the top bar, where, lower >51% height click on element spawns it on bottom. Or you can just have one possible location, always on top.

[aumarbello]

possible "spawn" location of the editing-bar, top and bottom

Don't understand, kindly elaborate pls

[gsantner]

I would really go for the latter, to just have one editbar, which just modifies the selected edit element in the image. having it it with multiple spawn locations just make it more conplicated to develop and use.

[gsantner]

oh, now i do understand what you think needs to be done.

in general: dont go the way to insert things twice. create a placeable component/view which includes said things (edittext, imagebuttons, popup..) and place that/use that twice. for bottom/top you dont need to rearrange things, as at some point there will be just one edittext, and that will be filled by the selected editable item that is clicked inside the image, so selecting a editable text visually directly on the image.

[aumarbello]

My point is I dont understand the concept you are putting forward, thats the explanation I'm seeking, by editbar you mean like an edittext with image buttons in the picture you uploaded?

which just modifies the selected edit element in image

What edit elements? Colors, font, text size?

having it it with multiple spawn locations

What are spawn locations, can you pls explain?

[aumarbello]

in general: dont go the way to insert things twice. create a placeable component/view which includes said things (edittext, imagebuttons, popup..) and place that/use that twice. for bottom/top you dont need to rearrange things, as at some point there will be just one edittext, and that will be filled by the selected editable item that is clicked inside the image, so selecting a editable text visually directly on the image.

Can relate more to this, but when you talk about

editable item that is clicked inside the image

What do you mean, cos the image is blank.

[aumarbello]

Picture this flow of creating a meme for the first time with a single editbar at the top of the screen, how do the user decide where to place the text being typed?

Or does the user click on an area in the image and the editbar becomes visible, based on the area clicked - is this where the spawn locations come in?

[gsantner]

Or does the user click on an area in the image and the editbar becomes visible, based on the area clicked - is this where the spawn locations come in?

exactly this is the final target

I dont have enough time to draw a full workflow right now, but the latest message is what it should go for in the end. I try to break it down to multiple parts, but its quite hard because everything is strongly tied together

[aumarbello]

Okay, i understand now, Will start working on it.

Guess i will remove the editing options of each text from the 'moar controls'

[gsantner]

maybe download https://play.google.com/store/apps/details?id=com.zombodroid.MemeGenerator to see how it could work with touchable elements inside the image. and how to deal with empty text elements.

BUT: The target is not to plainly copy :)

[gsantner]

Yeah, the moarcontrols can be completly removed then

[aumarbello]

Okay will download it

[gsantner]

Heres a short example demo of them: https://github.com/gsantner/gh_tmp/blob/master/ScreenRecord-2017-10-24-12-44-07.mp4

and as said, the first goal is to seperate controling a text-configuration from global to one item. everything at once is /would be a big task.

[aumarbello]

Okay I get it

[gsantner]

great, thanks for working on it 👍 😄

[gsantner]

Closing as implemented ; Should be extended in issue 82