notification bar enhanced #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for girlscript-asansol ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jayzsh
reviewed
Oct 6, 2022
index.html
Outdated
| @@ -92,9 +92,9 @@ | |||
|
|
|||
| <!-- Dismissable notification bar --> | |||
| <div class="notif-bar-btn" id="close"> | |||
| <div style="display: flex;width:73%;align-items: flex-end;"> | |||
| <div style="display: flex;width:73%;align-items: flex-end; justify-content: center;"><!--To center only the text and the button--> | |||
There was a problem hiding this comment.
Change align-items: flex-end to align-items: center to nicely centre the elements inside the notif-bar vertically.
jayzsh
reviewed
Oct 6, 2022
styles.css
Outdated
| @@ -33,12 +33,77 @@ body.dark { | |||
|
|
|||
| /* general styling for dismissable alert */ | |||
| .notif-bar-btn{ | |||
| background-color: #FE6155; | |||
| background-color: #00111c; /*mentioned color added*/ | |||
| color: white; | |||
| height: 3rem; | |||
| display: flex; | |||
| align-items: center; | |||
| justify-content: flex-end; | |||
There was a problem hiding this comment.
Change justify-content: flex-end; to justify-content: center;,
jayzsh
reviewed
Oct 6, 2022
index.html
Outdated
| <div style="margin-right: 1rem;">Join us on Discord!</div> | ||
| <a href="https://discord.gg/vYSspBkgNc"><Button style="background-color: rgb(54,66,86);color:white;margin-right: 1rem;border-radius: 0.5rem;">Join Discord</Button></a> | ||
| <a href="https://discord.gg/vYSspBkgNc"><button class="button-61" role="button">Join Discord</button></a><!--Material UI button added--> | ||
| </div> | ||
| <div style="display: flex;width: 10%;justify-content: flex-end; margin-right: 1rem;"> |
There was a problem hiding this comment.
Line 99: change style to position:fixed; right: 30px. That should be it.
jayzsh
requested changes
Oct 6, 2022
There was a problem hiding this comment.
@LalitChauhan27 You can now create a commit with the above changes. The PR will be updated automatically.
|
Hey @jay-io, can you please add the |
jayzsh
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Proposed Changes
Checklist
Screenshots