Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the contact us form #136

Merged
merged 6 commits into from
Oct 8, 2022
Merged

Added the contact us form #136

merged 6 commits into from
Oct 8, 2022

Conversation

yosaami
Copy link
Contributor

@yosaami yosaami commented Oct 7, 2022

Issue no: #56

  1. Made changes to index.html file and pasted the code
  2. made changes to styles.css file and pasted the code

I have pasted the "contact-us" form code under the given section
I have pasted the css code under the given section
@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit 3861869
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/63416b16a723af0008e91228
😎 Deploy Preview https://deploy-preview-136--girlscript-asansol.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GS Asansol! Thanks for making the PR, our team will soon review your PR. Thanks :)

@jayzsh
Copy link
Member

jayzsh commented Oct 8, 2022

Form looks great! I have a few suggestions (for desktop layout only, mobile looks perfect). Could you make it look like this instead?

  • Change bg illustration max-width to 100vw (I saw a 1100ish value somewhere in your CSS)
  • Change the inner container max-width to 80vw
  • Add a Submit button instead of the plain-text "Send". Use the below button style:
<!-- HTML !-->
<button class="button-38" role="button">Button 38</button>
/* CSS */
.button-38 {
  background-color: #FFFFFF;
  border: 0;
  border-radius: .5rem;
  box-sizing: border-box;
  color: #111827;
  font-family: "Lato";
  font-size: .875rem;
  font-weight: 600;
  line-height: 1.25rem;
  padding: .75rem 1rem;
  text-align: center;
  text-decoration: none #D1D5DB solid;
  text-decoration-thickness: auto;
  box-shadow: 0 1px 3px 0 rgba(0, 0, 0, 0.1), 0 1px 2px 0 rgba(0, 0, 0, 0.06);
  cursor: pointer;
  user-select: none;
  -webkit-user-select: none;
  touch-action: manipulation;
}

.button-38:hover {
  background-color: rgb(249,250,251);
}

.button-38:focus {
  outline: 2px solid transparent;
  outline-offset: 2px;
}

.button-38:focus-visible {
  box-shadow: none;
}
  • Add the references/sources for your form design as a comment in this thread, in case any. We'd have to give credits if required to avoid any potential copyright feuds.

Screenshot from 2022-10-08 07-58-46

Copy link
Member

@jayzsh jayzsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding commits to your fork's main branch will update your PR automatically.

Also please pull the changes first you are working on a old version (do git pull before pushing make sure you have synced your fork)

@soumali28 soumali28 requested a review from jayzsh October 8, 2022 12:14
@soumali28 soumali28 merged commit ed7a8f7 into gsasansol:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants