Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Accomplishment section text not aligned in mobile view #189

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix Accomplishment section text not aligned in mobile view #189

merged 2 commits into from
Oct 11, 2022

Conversation

capooods
Copy link
Contributor

Related Issue

Proposed Changes

  • Reconstructed achievement section to utilize Bootstrap grid.
  • Removed height / width not being responsive.
  • Reinserted achievement-wrapper to achievement-section to remove unnecessary margins for spacing between sections.

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

Before:

image
image
image

After:

image
image
image

@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited

✅ Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit e9f1e02
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/63448ca3933a980009a3d0e8
😎 Deploy Preview https://deploy-preview-189--girlscript-asansol.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jayzsh
jayzsh approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@jayzsh jayzsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@jayzsh jayzsh merged commit 403176c into gsasansol:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzsh jayzsh jayzsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@capooods @jayzsh