-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Navbar #196
Revamp Navbar #196
Conversation
✅ Deploy Preview for girlscript-asansol ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings from GS Asansol! Thanks for making the PR, our team will soon review your PR. Thanks :)
Hello i have done necessary changes and kindly revert back if any changes else accept the merge request. Thank You |
@theanimator20 Sorry for the delay. We've been a little busy. We'll review and merge it by midnight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the navbar in the mobile view will require a lot of adjustments. The alignment is off at places. Do you wanna try this again? Or you can always let us reassign this to someone else.
Yh i can work on it just tell me how u want the adjustments in mobile view |
Desktop view:
Mobile view:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theanimator20
Ok i will work on it but the light/theme button is at top-right only na?. Also for social link I'll remove the margin-top and make it kind of similar to that |
@jay-io i have worked on the issues u asked for do check it out |
@jay-io is it possible to accept the PR |
@theanimator20 We really appreciate your efforts. That's not all. We also love your follow-us mobile-view-only sidebar. Can you revert all the changes you did on the nav panel? We'll have someone else look into it. A few other contributors approached us and they wish to give it a shot. If you can still do it, you're most welcome to try and seek help in our server. If it's been tiresome for you, I'm afraid we can't merge a PR that kinda breaks stuff, just to help contributors win their T-shirts. We have milestones to reach, too. It's your call now. |
Ok i will try to work on overlapping issue if u need other changes do let me know once again |
Ah, yes the slight right-shift that the mobile navbar options have got. If you compare what we have currently deployed on our main branch and your mobile navbar, you'll know exactly what I'm talking about. Btw, glow effect is nice too, see if you can preserve it. |
Okay i would work on it |
@jay-io changes Resolved Check. |
Looks great now, thank you for contributing! |
@jay-io Thanks for having me here and i learned alot of new things and also thanks for Guiding Me. |
Related Issue
Proposed Changes
Checklist
] Testing your code in the local machine
Screenshots