Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified about us section #205

Merged
merged 7 commits into from
Oct 17, 2022
Merged

modified about us section #205

merged 7 commits into from
Oct 17, 2022

Conversation

savi001
Copy link
Contributor

@savi001 savi001 commented Oct 16, 2022

Related Issue

Proposed Changes

  • changed image of about us section
  • changed content of about us section
  • chaned hover effect of socials as join us button

Checklist

  • Documentation of the code
  • [x ] Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

Screenshot 2022-10-17 at 1 34 43 AM

@netlify
Copy link

netlify bot commented Oct 16, 2022

Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit 97b41f9
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/634d424ff65d470008e8cc52
😎 Deploy Preview https://deploy-preview-205--girlscript-asansol.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GS Asansol! Thanks for making the PR, our team will soon review your PR. Thanks :)

@jayzsh
Copy link
Member

jayzsh commented Oct 16, 2022

Looks great! Can you add a 30px bottom margin for the aboutus-image-container class in mobile view?

@jayzsh
Copy link
Member

jayzsh commented Oct 16, 2022

A few more things:

  • Add your name/username to the contributors' file
  • Seems like the DSA article has its line-endings changed. Go through these steps to revert your changes to prevent your commits from overwriting history.

Copy link
Member

@jayzsh jayzsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll merge your PR after these changes.

@savi001
Copy link
Contributor Author

savi001 commented Oct 17, 2022

@jay-io i think, i should also add some bottom margin margin in tablet view also , can i proceed ?

@savi001
Copy link
Contributor Author

savi001 commented Oct 17, 2022

I have added and changed as per your requirement

@jayzsh
Copy link
Member

jayzsh commented Oct 17, 2022

@savi001 Sure. You did great, thank you for contributing!

@jayzsh jayzsh merged commit 4eb783e into gsasansol:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants