Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar is mobile responsive now #38

Merged
merged 3 commits into from
Oct 2, 2022

Conversation

LalitChauhan27
Copy link
Contributor

Related Issue

Proposed Changes

  • navbar is now responsive for all devices
  • toggle bar is added for small screens
  • brand name is in one line instead of 2 seperate lines
  • added a gap between the logo and the brandname

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

P1
P2

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit 512af26
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/6339fbf49e9a6f0008654c9e
😎 Deploy Preview https://deploy-preview-38--girlscript-asansol.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@girlscript-asansol
Copy link
Contributor

girlscript-asansol commented Oct 2, 2022

@LalitChauhan27 For mobile view, brandname should be displayed beside the logo..not under it...other than that rest is ok. Also, change the toggle button color to black.

@girlscript-asansol girlscript-asansol requested review from girlscript-asansol and Debdeep1 and removed request for soumali28 and Debdeep1 October 2, 2022 10:04
@girlscript-asansol girlscript-asansol removed the request for review from soumali28 October 2, 2022 10:07
Copy link
Contributor

@Debdeep1 Debdeep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LalitChauhan27 you need to display brandname beside the logo and not under it. Also do change the color of toggle button to black. Other than that..the functionality is fine.

@Debdeep1 Debdeep1 removed the request for review from girlscript-asansol October 2, 2022 10:09
@LalitChauhan27
Copy link
Contributor Author

@Debdeep1 @girlscript-asansol Hey, I have made the changes that you have mentioned. Please review my latest commit.
P3
P4

@LalitChauhan27
Copy link
Contributor Author

@LalitChauhan27 you need to display brandname beside the logo and not under it. Also do change the color of toggle button to black. Other than that..the functionality is fine.

Hey @Debdeep1, I have made the changes that you have mentioned.

@Debdeep1 Debdeep1 self-requested a review October 2, 2022 20:50
@Debdeep1 Debdeep1 merged commit e4d7db2 into gsasansol:main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants