Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Header section #41

Merged
merged 6 commits into from
Oct 3, 2022
Merged

Add Header section #41

merged 6 commits into from
Oct 3, 2022

Conversation

thatsuman
Copy link
Contributor

Related Issue

Proposed Changes

  • Made header as proposed
  • Added asset images for development purpose
  • Changes are inside ../components/header/

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

  • Desktop
    image
  • Responsive / Mobile
    image

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit 4080bcf
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/633ada5e0898ae000884cb92
😎 Deploy Preview https://deploy-preview-41--girlscript-asansol.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@soumali28
Copy link
Member

soumali28 commented Oct 2, 2022

@thatsuman remove the logo from the header. Increase the font size. And try to make the curve div in the bottom if you can else do the above 2 changes i.e font and logo remove.
Also remove the conflicts. Do a git pull before pushing.

@thatsuman
Copy link
Contributor Author

thatsuman commented Oct 2, 2022

After changes:
image

@thatsuman thatsuman changed the title Add header section Add Header section Oct 2, 2022
@soumali28
Copy link
Member

@LalitChauhan27 Looks great. Thanks for your valuable contribution.

@soumali28 soumali28 merged commit 7160855 into gsasansol:main Oct 3, 2022
@LalitChauhan27
Copy link
Contributor

@LalitChauhan27 Looks great. Thanks for your valuable contribution.

Always happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Header Section
3 participants