Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #89 Resolved FAQ clickability working properly #91

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

Rahul-Palahwat
Copy link
Contributor

Related Issue

Proposed Changes

  • Toggling when clicking on arrow or question both

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

Can be opened when clicked anywhere on the question and same for close
Screenshot 2022-10-05 at 6 26 29 PM
Screenshot 2022-10-05 at 6 26 49 PM

@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for girlscript-asansol ready!

Name Link
🔨 Latest commit 3669bed
🔍 Latest deploy log https://app.netlify.com/sites/girlscript-asansol/deploys/633e4a108955a500088fd950
😎 Deploy Preview https://deploy-preview-91--girlscript-asansol.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rahul-Palahwat
Copy link
Contributor Author

Hey @girlscript-asansol please review this PR..

@jayzsh
Copy link
Member

jayzsh commented Oct 5, 2022

@Rahul-Palahwat The deployment preview shows otherwise. Can you check? Also, I think this feature breaks the smooth animation. Can you try to do something about it?

@Rahul-Palahwat
Copy link
Contributor Author

ohk @jay-io on it..

@Rahul-Palahwat
Copy link
Contributor Author

@jay-io , @girlscript-asansol review this PR

@soumali28
Copy link
Member

@Rahul-Palahwat Looks good, Thanks for your valuable contribution.

@soumali28 soumali28 self-requested a review October 6, 2022 04:57
@soumali28 soumali28 merged commit 84623c7 into gsasansol:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants