Expose Gumbo initialization options, output status #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
commented
Jan 31, 2024
Comment on lines
-17
to
+26
| let outputResult = withUnsafePointer(to: kGumboDefaultOptions) { (optionsPointer) -> Result<UnsafeMutablePointer<GumboOutput>, Never> in | ||
| .success(gumbo_parse_with_options(optionsPointer, htmlBuffer, htmlBuffer.count)) | ||
| let outputResult = withUnsafePointer(to: options) { (optionsPointer) -> UnsafeMutablePointer<GumboOutput> in | ||
| gumbo_parse_with_options(optionsPointer, htmlBuffer, htmlBuffer.count) | ||
| } | ||
|
|
||
| self.htmlBuffer = htmlBuffer | ||
|
|
||
| // Safe to force try here since the outputResult only returns success. | ||
| self.gumboOutput = try! outputResult.get() | ||
| self.gumboOutput = outputResult |
There was a problem hiding this comment.
@gshahbazian wrapping with Result seemed unnecessary here, but happy to revert that change if there's a good reason for it.
macdrevx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuring options like
max_tree_depthand checking to see whether the parse was successful.