Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disable static library build #134

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

ibaned
Copy link
Contributor

@ibaned ibaned commented Jan 7, 2019

even with BUILD_SHARED_LIBS=ON, this repository
will compile a libexodus.a
This commit introduces an option SEACASExodus_ENABLE_STATIC
that can be set to OFF to prevent any static library
compilation.
It should not affect anyone who doesn't explicitly set this
new option.

even with BUILD_SHARED_LIBS=ON, this repository
will compile a libexodus.a
This commit introduces an option SEACASExodus_ENABLE_STATIC
that can be set to OFF to prevent any static library
compilation.
It should not affect anyone who doesn't explicitly set this
new option.
Copy link
Member

@gsjaardema gsjaardema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the InstallSymLink needs to be inside the if block which builds the static library. As it is, I think that CMake will try to create a symbolic link to non-existant files.

@ibaned
Copy link
Contributor Author

ibaned commented Jan 7, 2019

Good point! I've pushed this additional change to the pull request.

@gsjaardema gsjaardema merged commit 732b5a1 into sandialabs:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants