Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorta bug. ASCII vs UTF8 in the output #1

Closed
rihlsul opened this issue Feb 17, 2018 · 1 comment
Closed

Sorta bug. ASCII vs UTF8 in the output #1

rihlsul opened this issue Feb 17, 2018 · 1 comment

Comments

@rihlsul
Copy link

rihlsul commented Feb 17, 2018

Discovered an interesting "bug", although maybe I'm stretching the tool beyond its intended use.

In the FontInfo makeJSON function, there are several places where a character is converted to (byte). This assumes ASCII characters. Simply swapping that to (int) seems to make it UTF8 friendly. (Character values like int of 61440, etc). It otherwise handles it just fine.

Not sure if you still maintain this, but in case, there you go.

@rihlsul
Copy link
Author

rihlsul commented Feb 17, 2018

Disregard. I have to do a pretty massive rewrite to the Roblux LUA handling as well to support UTF8.

@rihlsul rihlsul closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant