-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match highlighting draws one line below matches #20
Comments
Hmm. We were seeing this in some browsers before adding a delay to the initial render - I believe it was related to font loading/initialization. I'm unable to reproduce, but it might make sense to bump up the delay slightly in the hopes that it solves this issue. To confirm, the highlighting also fixes itself if you edit the Text or the Expression? (basically anything that causes the highlights to be redrawn) |
I've been playing here, and unable to reproduce since I changed the window size. Several reloads, lots of resizes, and nothing. When it was happening, I was able to change the regex and highlighting would update, but still be off. Never tried editing text. |
Have you tried clearing your cache to see if you could reproduce? That should cause the font to reload. |
Cleared cache, and still can't reproduce.
|
Ok. Thanks for trying. I've added a delayed call to the resize method in the hopes it solves the issue. I'll leave this open for now. Once we deploy the fix we'll give it a couple weeks to see if it resurfaces before closing. |
Alright, we were finally able to isolate this issue, and have put in a fix. It should go live in the next few days. I'm going to close this for now, but feel free to reopen if you see the issue again after April 11, 2014. |
Loaded site (www.regexr.com) and default regex has highlighting errors. Top two paragraphs display fine, but highlighting for "Sample" and uppercased alphabet in the third paragraph is displayed on the line below the actual match. Resizing the browser window fixes the issue. It may be related to window width, but unfortunately I cannot reproduce and do not have a full screenshow showing window size.
Seen in Chrome 33.0.1750.154 on Win7.
![regexr_chromebug](https://cloud.githubusercontent.com/assets/7192697/2624079/e148b1fe-bd1e-11e3-98d3-0a645fa388c1.png)
The text was updated successfully, but these errors were encountered: