Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match highlighting draws one line below matches #20

Closed
cjtucker opened this issue Apr 6, 2014 · 6 comments
Closed

Match highlighting draws one line below matches #20

cjtucker opened this issue Apr 6, 2014 · 6 comments

Comments

@cjtucker
Copy link

cjtucker commented Apr 6, 2014

Loaded site (www.regexr.com) and default regex has highlighting errors. Top two paragraphs display fine, but highlighting for "Sample" and uppercased alphabet in the third paragraph is displayed on the line below the actual match. Resizing the browser window fixes the issue. It may be related to window width, but unfortunately I cannot reproduce and do not have a full screenshow showing window size.

Seen in Chrome 33.0.1750.154 on Win7.
regexr_chromebug

@gskinner
Copy link
Owner

gskinner commented Apr 6, 2014

Hmm. We were seeing this in some browsers before adding a delay to the initial render - I believe it was related to font loading/initialization. I'm unable to reproduce, but it might make sense to bump up the delay slightly in the hopes that it solves this issue.

To confirm, the highlighting also fixes itself if you edit the Text or the Expression? (basically anything that causes the highlights to be redrawn)

@cjtucker
Copy link
Author

cjtucker commented Apr 6, 2014

I've been playing here, and unable to reproduce since I changed the window size. Several reloads, lots of resizes, and nothing.

When it was happening, I was able to change the regex and highlighting would update, but still be off. Never tried editing text.

@gskinner
Copy link
Owner

gskinner commented Apr 6, 2014

Have you tried clearing your cache to see if you could reproduce? That should cause the font to reload.

@cjtucker
Copy link
Author

cjtucker commented Apr 6, 2014

Cleared cache, and still can't reproduce.
On Apr 5, 2014 11:55 PM, "Grant Skinner" notifications@github.com wrote:

Have you tried clearing your cache to see if you could reproduce? That
should cause the font to reload.

Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-39658582
.

@gskinner
Copy link
Owner

gskinner commented Apr 7, 2014

Ok. Thanks for trying. I've added a delayed call to the resize method in the hopes it solves the issue. I'll leave this open for now. Once we deploy the fix we'll give it a couple weeks to see if it resurfaces before closing.

@gskinner
Copy link
Owner

gskinner commented Apr 7, 2014

Alright, we were finally able to isolate this issue, and have put in a fix. It should go live in the next few days. I'm going to close this for now, but feel free to reopen if you see the issue again after April 11, 2014.

3a4186e

@gskinner gskinner closed this as completed Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants