Fix jest / babel config merging for CRA v4 #207
Conversation
mormahr
force-pushed
the
fix-cra4-babel-jest-merge
branch
from
87eec70
to
3d41af8
Compare
|
Looks good, thank you :) Yeah I wonder if CRACO should really be backward compatible? Doesn't make much sense to me right now. What do you think? |
I mean not down to 2.x, because the README states 3.x (and in the future 4.x), but if it's only this and the eslint bug, then I don't see the need to drop support for 3.x. Probably makes upgrading easier if 3.x is supported for the time being. |
|
Make sense! We'll see what's needed to fix eslint. |
|
Thank you for this quick fix, any idea when the new release with this fix will be out? |
|
@AO19 I will publish a release tonight, thanks for the reminder! :) |
|
Released as https://www.npmjs.com/package/@craco/craco/v/5.8.0 sorry for the delay. |
|
Thank you very much, no worries. |
As mentioned in #205 (or more specifically this comment) jest breaks with CRA v4.
The regex key, that determines if a file should be transformed with babel, changed. This causes craco to not be able to merge the custom babel config into the jest config.
The new key is
"^.+\.(js|jsx|mjs|cjs|ts|tsx)$".For backwards compatibility I used the same naming schema / method as for the 2.1.0 change before (this should probably be removed, as 2.1.0 isn't supported anymore anyways).