Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDP-1416 Add support for workleap certificate store #60

Merged
merged 2 commits into from
May 15, 2024

Conversation

starcraft66
Copy link
Member

Description of changes

Added support to mount Workleap's certificate store over the container's internal certificate store. The store comes from a well-known Key Vault who's information must be filled in via helm values.

Breaking changes

Removed the volumes section that was briefly introduced (without being documented) into the chart because it is redundant and less flexible than extraVolumes. No one is using it AFAIK.

Additional checks

Tested using server-side dry-run on a dev cluster:

PS C:\Users\tristan.g-hane\src\gsoft-helm-charts> helm template --set certificateStore.enabled=true test ./charts/aspnetcore --debug | kubectl apply --dry-run=server -f -
install.go:218: [debug] Original chart version: ""
install.go:235: [debug] CHART PATH: C:\Users\tristan.g-hane\src\gsoft-helm-charts\charts\aspnetcore

poddisruptionbudget.policy/test-pdb created (server dry run)
service/test-service created (server dry run)
deployment.apps/test-deployment created (server dry run)
ingress.networking.k8s.io/test-ingress created (server dry run)
secretproviderclass.secrets-store.csi.x-k8s.io/internal-dns-keyvault created (server dry run)
  • Updated the documentation of the project to reflect the changes
  • Added new tests that cover the code changes

@starcraft66 starcraft66 requested a review from a team as a code owner May 15, 2024 19:01
charts/aspnetcore/templates/secretproviderclass.yaml Outdated Show resolved Hide resolved
charts/aspnetcore/values.yaml Outdated Show resolved Hide resolved
@starcraft66 starcraft66 merged commit 1cf11fc into main May 15, 2024
7 checks passed
@starcraft66 starcraft66 deleted the feature/tgh/idp-1416 branch May 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants