Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #13

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Version Packages #13

merged 2 commits into from
Nov 22, 2021

Conversation

github-actions[bot]
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@igloo-ui/card@0.0.2

Patch Changes

  • fa1a096: ## Card component

    Cards are used a the background that contains elements of a parent ensemble.

    Component API

    name description
    children The content to display inside the component
     size  Changes the size of card, giving more or less padding small, medium, large
    dataTest  Add a data-test tag for automated tests

@netlify
Copy link

netlify bot commented Nov 22, 2021

✔️ Deploy Preview for igloo-ui ready!

🔨 Explore the source changes: f7958b9

🔍 Inspect the deploy log: https://app.netlify.com/sites/igloo-ui/deploys/619bf5091a778a0007dce156

😎 Browse the preview: https://deploy-preview-13--igloo-ui.netlify.app

Copy link
Contributor

@ofrogon ofrogon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally good, but one of the sentence on the CHANGELOG.md file for the Card component could be improve.


- fa1a096: ## Card component

Cards are used a the background that contains elements of a parent ensemble.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this sentence and I don't understand what we are trying to explain here.

Maybe (if I understand correctly) this version could be clearer:

Cards are used as a visual container for a sub-group of elements in a parent container.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je prend en note et ouvre une issue avec ton commentaire.

@franckgaudin franckgaudin merged commit 18b597b into main Nov 22, 2021
@franckgaudin franckgaudin deleted the changeset-release/main branch November 22, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants