Merge pull request #1208 from gsoft-inc/fix-icon-button-loading-aria-…

…label-missing

fix: missing aria-label on loading IconButton

.changeset/rare-eyes-fly.md

@@ -0,0 +1,5 @@
+---
+"@orbit-ui/components": patch
+---
+
+Fix missing aria-label on IconButton's Spinner when loading is true

packages/components/src/button/src/IconButton.tsx

@@ -128,6 +128,7 @@ export function InnerIconButton(props: InnerIconButtonProps) {
 
     const loadingMarkup = loading && (
         <Spinner
+            aria-label="Loading..."
             className="o-ui-button-spinner"
             color={variant === "primary" ? "alias-static-white" : undefined}
             role="presentation"

packages/components/src/button/tests/jest/IconButton.test.tsx

@@ -73,6 +73,23 @@ test("when loading is true, the button should prevent onClick", async () => {
     await waitFor(() => expect(handler).not.toHaveBeenCalled());
 });
 
+// ***** Aria *****
+
+test("when loading is true, the spinner should have an aria-label", async () => {
+    renderWithTheme(
+        <IconButton
+            loading
+            aria-label="Add"
+        >
+            <AddMajorIcon />
+        </IconButton>
+    );
+
+    const spinner = screen.getByRole("presentation");
+
+    expect(spinner).toHaveAttribute("aria-label");
+});
+
 // ***** Api *****
 
 test("can focus the button with the focus api", async () => {