Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): Created an eslint plugin to add rules and configuration #1231

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

alexasselin008
Copy link
Member

Summary

Created a new eslint plugin that allows to use the design system with jsx-a11y plugin. In the future, this eslint plugin will include accessibility pointers, deprecation notices, and other helpful tips

I updated the installation documentation to reflect this new plugin

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 3d78590

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@orbit-ui/eslint-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for sg-orbit ready!

Name Link
🔨 Latest commit 3d78590
🔍 Latest deploy log https://app.netlify.com/sites/sg-orbit/deploys/65132015b4b32f00088b75c4
😎 Deploy Preview https://deploy-preview-1231--sg-orbit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for sg-storybook ready!

Name Link
🔨 Latest commit 3d78590
🔍 Latest deploy log https://app.netlify.com/sites/sg-storybook/deploys/65132015e0992d00089aa8e1
😎 Deploy Preview https://deploy-preview-1231--sg-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/getting-started/Installation.stories.mdx Outdated Show resolved Hide resolved
docs/getting-started/Installation.stories.mdx Outdated Show resolved Hide resolved
tooling/eslint-plugin/lib/config/jsx-a11y.ts Show resolved Hide resolved
tooling/eslint-plugin/package.json Outdated Show resolved Hide resolved
@patricklafrance
Copy link
Member

The new orbit plugin should be configured in the Orbit repository to dogfood our own plugin :)

@alexasselin008 alexasselin008 merged commit f1deae1 into master Sep 27, 2023
8 checks passed
@alexasselin008 alexasselin008 deleted the feature/eslint-config branch September 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants