Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help section to override suffix and separator #5

Closed
invisibleninja06 opened this issue Jul 23, 2020 · 2 comments
Closed

Add help section to override suffix and separator #5

invisibleninja06 opened this issue Jul 23, 2020 · 2 comments

Comments

@invisibleninja06
Copy link

It unclear to me how to override the random suffix generation as well as how to change the separator used.

In my case for storage accounts I rather not have 0 as separator, in fact id like no separator at all.
The following does not work

module "csazname_storage_account" {
  source    = "gsoft-inc/naming/azurerm//modules/storage/storage_account"
  name      = lower(var.rg_rs_basename)
  prefixes  = ["st", lower(var.rg_project), lower(var.rg_projecttype)]
  separator = ""
}

This results in An argument named "separator" is not expected here.

Setting the suffixes to [] results in regular generation, since its the default.
Setting the suffixes to null results in error
setting suffixes to [""] result in no suffix but a separator is still present

Appreciate any assistance

yohanb pushed a commit that referenced this issue Oct 23, 2020
… correctly override the suffix with an empty array.
@yohanb
Copy link
Contributor

yohanb commented Oct 23, 2020

Hey @invisibleninja06. I know I'm late to the party but I wanted to let you know I've made the changes to the modules in order to support an empty string separator and also empty array suffix.
Cheers!

@yohanb yohanb closed this as completed Oct 23, 2020
@invisibleninja06
Copy link
Author

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants