Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDP-1715] Improve docs to show how to modify Event Grid client options and expose the client name #143

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

asimmon
Copy link
Member

@asimmon asimmon commented Jun 19, 2024

Description of changes

  • Add doc to show how to configure EventGridPublisherClientOptions and EventGridClientOptions.
  • Changed the internal client names (previously EventPropagationClient and NamespaceTopicClient) to a public, single name DomainEventPropagation
    • I search for usage of these strings in our codebases => no results
    • It's ok to reuse the same string. .NET named options work per option type AND option name. We already did that in another lib (auditing).

Breaking changes

  • The Event Grid client names have changed but nobody was refering to them
  • The client name is now publicly exposed for people to override the options

Additional checks

  • Updated the documentation of the project to reflect the changes
  • Added new Modified tests that cover the code changes

@asimmon asimmon requested a review from a team as a code owner June 19, 2024 16:55
README.md Show resolved Hide resolved
@asimmon asimmon merged commit b2fabcb into main Jun 19, 2024
4 checks passed
@asimmon asimmon deleted the feature/idp-1715-configure-client-options branch June 19, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants