Skip to content

Commit

Permalink
[IDP-1470] Change default MaxConnectionIdleTime to one minute (#74)
Browse files Browse the repository at this point in the history
* Change default MaxConnectionIdleTime to one minute
  • Loading branch information
asimmon committed May 16, 2024
1 parent 7fe5e0f commit 41524d8
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/Workleap.Extensions.Mongo/MongoClientProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,18 @@ internal sealed class MongoClientProvider : IMongoClientProvider, IDisposable
// https://github.com/mongodb/mongo-csharp-driver/blob/v2.17.1/src/MongoDB.Driver/MongoDefaults.cs#L32
private static readonly TimeSpan DefaultThirtySecondsConnectTimeout = TimeSpan.FromSeconds(30);

// https://github.com/mongodb/mongo-csharp-driver/blob/v2.25.0/src/MongoDB.Driver/MongoDefaults.cs#L34
private static readonly TimeSpan DefaultTenMinutesMaxConnectionIdleTime = TimeSpan.FromMinutes(10);

// Officevibe also uses a 60 seconds socket timeout, it's better than the infinite default
private static readonly TimeSpan ReasonableSocketTimeout = TimeSpan.FromSeconds(60);

// Officevibe also uses a 10 seconds connect timeout
private static readonly TimeSpan ReasonableConnectTimeout = TimeSpan.FromSeconds(10);

// Officevibe also uses a 60 seconds max connection idle time
private static readonly TimeSpan ReasonableMaxConnectionIdleTime = TimeSpan.FromSeconds(60);

private readonly IServiceProvider _serviceProvider;
private readonly List<IDisposable> _disposableDependencies;

Expand Down Expand Up @@ -66,6 +72,11 @@ private IMongoClient CreateMongoClient(string clientName)
settings.ConnectTimeout = ReasonableConnectTimeout;
}

if (settings.MaxConnectionIdleTime == DefaultTenMinutesMaxConnectionIdleTime)
{
settings.MaxConnectionIdleTime = ReasonableMaxConnectionIdleTime;
}

var eventSubscriberFactories = this._serviceProvider.GetServices<IMongoEventSubscriberFactory>();
var eventSubscribers = eventSubscriberFactories.SelectMany(x => x.CreateEventSubscribers(clientName)).ToList();
options.PostConfigureEventSubscribers?.Invoke(eventSubscribers);
Expand Down

0 comments on commit 41524d8

Please sign in to comment.