[IDP-1222] Add Roslyn rule to flag response type mismatch between annotation and method return #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_and_results # Conflicts: # src/Directory.Build.props # src/tests/WebApi.OpenAPI.SystemTest/WebApi.OpenAPI.SystemTest.csproj
meziantou
reviewed
May 1, 2024
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/Internals/RoslynExtensions.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenApi.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/tests/Workleap.Extensions.OpenAPI.Analyzers.Tests/BaseAnalyzerTest.cs
Outdated
Show resolved
Hide resolved
...Workleap.Extensions.OpenAPI.Analyzers.Tests/CompareTypedResultWithAnnotationAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
...rkleap.Extensions.OpenAPI.Analyzers.Tests/Workleap.Extensions.OpenAPI.Analyzers.Tests.csproj
Outdated
Show resolved
Hide resolved
PrincessMadMath
previously approved these changes
May 2, 2024
src/Workleap.Extensions.OpenAPI.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Workleap.Extensions.OpenAPI.Analyzers/CompareTypedResultWithAnnotationAnalyzer.cs
Show resolved
Hide resolved
PrincessMadMath
previously approved these changes
May 2, 2024
PrincessMadMath
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added Roslyn analyzer and tests to flag for mismatch between return type indicated by method signature and response type annotations.
Breaking changes
Pre-release format so no current users, but new users will need to fix mismatches if there are any.
Additional checks
Test on an API