add status code checks #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
force-pushed
the
feature/http-status-checks
branch
from
57c20c9
to
37a3f2f
Compare
gsquire
reviewed
Apr 23, 2020
Cargo.toml
Outdated
| @@ -18,6 +18,7 @@ serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| url = "2.1" | |||
| failure = "0.1" | |||
| http = "0.2.1" | |||
There was a problem hiding this comment.
Does the reqwest crate not re-export these?
|
Thanks for the PR! Just one minor thing and I think it will be ready to merge after that. |
|
@gsquire Sounds good, done! |
|
I'm relatively new to Rust development, although I have been on it in many other languages, so the concept of re-export in a 3rd party package is still kinda on and off in my head, although I use it heavily in my projects. |
|
@gsquire shall I bump the version as well? |
|
Nice work, @ruseinov! Thanks again. |
|
FYI I bumped the version to 0.11.0 since I would consider this a breaking change. I published it now so it should be available on https://crates.io soon. CC @kanekv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50