Allow setting the the host endpoint #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easier testing for consumers of this library. The endpoint can be set to be a local server to verify the email is sent correctly.
gsquire
requested changes
Jun 29, 2023
src/client.rs
Outdated
| @@ -19,6 +19,7 @@ static API_URL: &str = "https://api.sendgrid.com/api/mail.send.json?"; | |||
| #[derive(Clone, Debug)] | |||
| pub struct SGClient { | |||
| api_key: String, | |||
| host: Option<String>, | |||
There was a problem hiding this comment.
Maybe we can just have this be a String and set it to the API_URL value in new? IMO we should always have a host.
The set_host function can just mutate the value.
There was a problem hiding this comment.
Great point, will make that change. Would it be better for backwards compatibility to create a new constructor such as Actually, new_with_host so that existing calls to new continue to work?set_host can covert this.
Changes from PR feedback
|
LGTM, thanks! |
|
This will be published in version 0.19.1 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows easier testing for consumers of this library. The endpoint
can be set to be a local server to verify the email is sent correctly.