Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off spellcheck in main textarea #2

Closed
wants to merge 1 commit into from

Conversation

geoffbeier
Copy link

I don't have a quick way to test this, but it's a small change that would kill the red squigglies in the playground, unless I've made a typo.

@macarc
Copy link
Contributor

macarc commented Apr 12, 2021

I don't have a quick way to test this

Yep, it does work (I have this change in my PR too)

@geoffbeier
Copy link
Author

I have this change in my PR too

Nice. I looked briefly and didn't spot it. In that case, yours is 100% better than this one. The only sense behind this oneliner, then, would be to get something quick and interim in place while the larger and better patch can be reviewed.

@gsquire
Copy link
Owner

gsquire commented Apr 12, 2021

Thanks so much for the PR. Seeing as this patch made it's way into the other linked PR, I'll add it in there. I plan on reviewing it this evening after work.

@gsquire
Copy link
Owner

gsquire commented Apr 13, 2021

I merged the other PR. If you see any other things that need a fix, I'd be more than happy to review it!

@gsquire gsquire closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants