Special ccache handling for {HOSTNAME} acceptor #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozencemetery I got confirmation that this solves the actual problem on #234, would be nice to review and merge. |
frozencemetery
previously requested changes
Oct 15, 2020
frozencemetery
force-pushed
the
multi_hostname_proxy
branch
from
d399969
to
f906f11
Compare
This test shows that currently GssapiAcceptor {HOSTNAME} option will
break the S4U2Proxy case.
Signed-off-by: Simo Sorce <simo@redhat.com>
[rharwood@redhat.com: nits]
This applies only to the case when GssapiS4U2Proxy is enabled.
When using the {HOSTNAME} acceptor, the principal used in the server
ccache can vary with each request. GSSAPI does not handle gracefully
a request to resolve a ccache if there is already another credential
under a different name. Even with ccache collections GSSAPI will
resolve an existing ccache from the collection if any is available and
throw an error if it does not match the desired_name. This even if
there is a client_keytab that could be used to initiate a new cache in
the collection with the right name.
Therefore in case GssapiAcceptor is set to the special value {HOSTNAME},
instead of using the provided ccache or the process default ccache we
create a new ccache named after the hostname in the delegated ccache
directory. This directory is required when the S4U2Proxy mode is enabled
so we are guaranteed to have it available an writable.
Signed-off-by: Simo Sorce <simo@redhat.com>
[rharwood@redhat.com: nits]
frozencemetery
force-pushed
the
multi_hostname_proxy
branch
from
f906f11
to
5a6e6be
Compare
|
Your changes look good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting part of a commit message in this PR:
When using the {HOTNAME} acceptor the principal used in the server
ccache can vary with each request. GSSAPI does not handle gracefully
a request to resolve a ccache if there is already another credential
under a different name.
Fixes #234