Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-unique file names; match metadata based on unique file paths #2

Open
gszep opened this issue Jan 25, 2021 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gszep
Copy link
Owner

gszep commented Jan 25, 2021

The issue is cross-platform compatibility. FlowJo stores the absolute path that contains os user specific information that we do not want to parse. I currently use basename(path) to uniquely identify the sample in the .wsp file, but this is not general. How do I truncate path to the relative path of the .fcs file from the .wsp file?

@gszep gszep added enhancement New feature or request good first issue Good for newcomers labels Mar 1, 2021
@gszep
Copy link
Owner Author

gszep commented Mar 1, 2021

make code throw error if this requirement is not satisfied until I fix this
@JuliaRegistrator register

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/31030

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.3 -m "<description of version>" 2ecbc5f1c7b642eb235ee3b4ae30702d07d7f54e
git push origin v0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants