Skip to content

Commit

Permalink
Apply changes based on comments in
Browse files Browse the repository at this point in the history
  • Loading branch information
gt-arylla committed Nov 9, 2023
1 parent ded2314 commit 428f853
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ios/Frame Processor/FrameProcessorPlugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@
objc_name : NSObject<FrameProcessorPluginBase> \
@end \
\
@interface objc_name (FrameProcessorPlugin) \
@interface objc_name (FrameProcessorPlugin) <FrameProcessorPluginBase> \
@end \
@implementation objc_name (FrameProcessorPlugin) \
\
__attribute__((constructor)) static void VISION_CONCAT(initialize_, objc_name)() \
__attribute__((constructor)) static void VISION_CONCAT(initialize_, objc_name)() \
{ \
[FrameProcessorPluginRegistry addFrameProcessorPlugin:@"__" @ #name callback:^id(Frame* frame, NSArray<id>* args) { \
return [objc_name callback:frame withArgs:args]; \
Expand Down
9 changes: 9 additions & 0 deletions ios/Parsers/AVCaptureColorSpace+descriptor.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ extension AVCaptureColorSpace {
case "srgb":
self = .sRGB
return
case "appleLog":
if #available(iOS 17, *) {
self = .appleLog
} else {
throw EnumParserError.unsupportedOS(supportedOnOS: "17")
}
return
default:
throw EnumParserError.invalidValue
}
Expand All @@ -37,6 +44,8 @@ extension AVCaptureColorSpace {
return "p3-d65"
case .sRGB:
return "srgb"
case .appleLog:
return "appleLog"
default:
fatalError("AVCaptureDevice.Position has unknown state.")
}
Expand Down

0 comments on commit 428f853

Please sign in to comment.