Removed universal newline + shell=true

gtalarico · May 12, 2018 · 55a018d · 55a018d
1 parent 80aea53
commit 55a018d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pipenv_pipes/pipenv.py b/pipenv_pipes/pipenv.py
@@ -8,16 +8,14 @@ def PipedPopen(cmds, **kwargs):
     timeout = kwargs.pop('timeout', None)
     env = kwargs.pop('env', dict(os.environ))
     proc = Popen(
-        ' '.join(cmds),
+        cmds,
         stdout=PIPE,
         stderr=PIPE,
-        universal_newlines=True,
         env=env,
-        shell=True,
         **kwargs
     )
     out, err = proc.communicate(timeout=timeout)
-    output = out.strip() or err.strip()
+    output = out.decode().strip() or err.decode().strip()
     code = proc.returncode
     return output.strip(), code