Allow ORM Meta options to be lookups at runtime (not import time) #268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 95.74% 95.75%
=======================================
Files 18 18
Lines 917 919 +2
=======================================
+ Hits 878 880 +2
Misses 39 39
|
| @@ -171,6 +187,8 @@ def _get_meta(cls, name: str, default: Any = None, required: bool = False) -> An | |||
| if required and not hasattr(cls.Meta, name): | |||
| raise ValueError(f"{cls.__name__}.Meta.{name} must be defined") | |||
| value = getattr(cls.Meta, name, default) | |||
| if callable(value): | |||
There was a problem hiding this comment.
Beyond a nit and this particular usage is already very concise so feel free to completely disregard, PR looks great but was poking around in Python 3.10 docs and this seems like a case where match (ref PEP 634/635/636 could be used in a world where 3.10 is the minimum supported version ie:
match value:
case callable_func := callable(value):
value = callable_func()
There was a problem hiding this comment.
I will admit to not having my head wrapped around the match syntax (or soft keywords in general) but I think it's fair to say we shouldn't use it if it's not present (or available via __future__) in all supported Python versions.
mesozoic
force-pushed
the
runtime_orm_meta
branch
from
d3eeb66
to
3efa2d6
Compare
mesozoic
force-pushed
the
runtime_orm_meta
branch
from
3efa2d6
to
dd46375
Compare
This allows the
Metaclass inside each ORM model to provide a callable that will be executed whenever the ORM requests one of its meta properties. The use case we have is to be able to provide API keys via global configuration singletons or environment variables which might not be loaded at import time but will be present at runtime.Resolves #192