Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return_fields_by_field_id to Table.update() #320

Merged
merged 4 commits into from Nov 27, 2023

Conversation

marks
Copy link
Contributor

@marks marks commented Nov 25, 2023

As requested and discussed in #307 , this adds support for setting return_fields_by_field_id on Table.update() calls.

The Airtable API began supporting this on 10/3/2023.

@marks marks marked this pull request as draft November 25, 2023 21:30
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b30630) 99.60% compared to head (27a8100) 99.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          24       24           
  Lines        1791     1791           
=======================================
  Hits         1784     1784           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marks
Copy link
Contributor Author

marks commented Nov 25, 2023

BTW - maintainers - is there documentation for running integration tests locally? I was able to figure out what I needed to create in Airtable in tests/integration/conftest.py and related tests, but just curious if I had missed something

@marks marks marked this pull request as ready for review November 25, 2023 21:36
@mesozoic
Copy link
Collaborator

Thanks for adding this, @marks! Right now the repo requires all commits to be signed; so that you get credit for the PR, could you enable signed commits and rebase your branch?

We do not have any documentation for the integration tests; that's a todo I never got around to. They should work out-of-the-box with creator privileges on the test base, and I just sent you an invite for that. However, the non-integration test suite should still provide as close to 100% test coverage as possible.

Test now fails but next commit should implement support for it
previously failing test now passes
locally, `docs/build/api.html#pyairtable.Table.update` shows the arg definition now
@marks
Copy link
Contributor Author

marks commented Nov 27, 2023

Ah, thank you @mesozoic !

All commits for this branch/PR should be signed/verified now.

@mesozoic mesozoic merged commit 59534ab into gtalarico:main Nov 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants