Use improved enterprise "get users" endpoint, and simplify collaborations model #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
enterprise.user()
orenterprise.users()
now uses the get users by id or email endpoint, which used to only accept emails (at least, according to its documentation). This removes the need to iterate over IDs and call get user by id one by one.collaborations=False
as a keyword argument touser()
,users()
, orgroup()
. This removes the need for type-checked code to doif user.collaborations: ...
to check againstNone
.