Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update airtable.py #65

Closed
wants to merge 2 commits into from
Closed

Update airtable.py #65

wants to merge 2 commits into from

Conversation

johruss
Copy link

@johruss johruss commented Jan 3, 2020

Hello, as said in the request.request, a timeout should be specified.
I have an unstable internet connection, and this connector will hand for an unspecified amount of time.
Putting the timeout parameter solves this problem.

Hello, as said in the request.request, a timeout should be specified.
I have an unstable internet connection, and this connector will hand for an unspecified amount of time.
Putting the timeout parameter solves this problem.
@gtalarico
Copy link
Owner

@johruss don't you need to include the param in the call to requests session?

@johruss
Copy link
Author

johruss commented Jan 11, 2020

@johruss don't you need to include the param in the call to requests session?

I had a blonde moment :)
Sorry. I've corrected that.

@gtalarico
Copy link
Owner

Actually, not sure hard coding different defaults for timeouts here is the best way to go about this.
Maybe we can store a Airtable._timeout tuple that can be configured by the user during init.

table = Airtable(..., timeout=(10,30))

ps: that's how pyGithub did it
https://pygithub.readthedocs.io/en/latest/github.html#main-class-github

@johruss
Copy link
Author

johruss commented Feb 15, 2020

Yes, this may be better.
Is this something you could do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants