Refactor and add docs docs docs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtank
reviewed
Mar 3, 2019
| @@ -15,13 +18,12 @@ import ( | |||
|
|
|||
| // FieldElement represents an element of the field GF(2^255-19). An element t | |||
| // represents the integer t[0] + t[1]*2^51 + t[2]*2^102 + t[3]*2^153 + | |||
| // t[4]*2^204. The zero value is a valid zero element. | |||
| // t[4]*2^204. Each limb must not exceed 2^54 - 1 to be valid. | |||
There was a problem hiding this comment.
Limbs are allowed to grow between operations, but must not exceed 54 bits to remain valid input for multiplications.
There was a problem hiding this comment.
Ok, I shouldn't write docs about this without knowing what I'm doing.
We really need to figure out the input and output ranges for each operation, and either make it all self-consistent, or if that's not possible put the ranges in the docs.
It would return an invalid element if the input was greater than 2^54 - 1.
FiloSottile
force-pushed
the
filippo/pretty
branch
from
a26d1a3
to
73abf15
Compare
gtank
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.