Unable to adjust the zones in the .jar or the .deb versions.

[user90919293949596979899]

I can't change the zones in the editor for some reason.

[lfuelling]

The zone text fields stay diabled and without value regardless of the zone selected and the "gang wars" setting.

[rain1]

Would it be possible to explain in few words how zones tab is meant to work and how to enable those fields? I see there is SelectableItemVariable which gets the zones and parameter. And then there is handleEvent that sets disabled. Would it be possible to tell in 1 or 2 sentences what is the intent behind this handleEvent? And whats the idea behind SelectedItems custom iterator logic where hasNext? I kind of understand what is supposed to happen there but I feel like some explanation might help.

Updating zones manually in debugger worked. Also selecting areas on map seems to work. So it seems like what needs work is getting inputs to respond to changes. if you are too busy yourself, having a few words explanation about how you intended it to work might lower the entry barrier for those who might want to try to fix this.

[lfuelling]

Unfortunately, I didn't write that (or most of) the code, I just added some macOS-specific features, started work on support for garages and fixed the project structure, build process and documentation.

I tried multiple times to understand what that code is supposed to do but I always get lost on the way and end up with no time left. Since you mentioned that using the debugger works, I'd suspect some sort of race condition or as you've mentioned an issue with reading inputs.
I don't really understand that part of the code and haven't properly coded Java in almost three years now, so I'm sorry but I can't give you any more info on the specifics of the Zone tab, than:

From what I understand, users are supposed to select an area of the map, which will then result in the zones on the map being highlighted, so they can set the gangs that are active in that zone.
The handleEvent method you mentioned probably sets the disabled state of the text fields, they should be disabled when nothing is selected, but I'm not sure if that event even is fired correctly when an area is selected.

[rain1]

Tnx. I thought you were initial developer as this git was the first in google. Where does the code come from? Maybe I can get some info from original source.

But thanks for mentioning that you also didnt understand that code. Now I know I am not the only one. When I was reading it then I was also feeling that I should first refactor the code to comply with clean code standards and then try to understand it.

[lfuelling]

The website linked at the repository start page is the original website, @paul35621 is the original developer.
I just took over maintainership hoping I could fix what kept it from working for the macOS version, add some quality-of-life improvements, and maybe even get some outside contributions that fix other issues by hosting it in a more accessible manner on GitHub.

You can try reaching out to him using email if that's still available on his website, but I can't guarantee that he'll respond.

In any case, even if you just clean up the code a bit to make it more readable, any contribution back is more than welcome, maybe it will help someone else who tries to tackle this issue.

EDIT: Apparently there is an older version on the website that has a working zones tab, see this comment.

[rain1]

took over maintainership

That means you took the ownership of original repository? The account you linked does not seem to have any GTA related repos.

But anyways thanks for pointing out that it was working in older version. That means I could probably use Intellij decompiler to extract the old code.

Since I personally don't play GTA SA that much I don't think I would spend more than 1 or 2 weekends on fixing that stuff. If it takes longer than that I would better leave it for someone who plays this game everyday.

[lfuelling]

No, the code was previously only available on pauls website (linked at the top of this repo) as a zip without any way to contribute changes, so I wrote an email asking if he would be okay with putting the project on GitHub so I could fix the issues I have and maybe develop further features, to which he replied that I should then also take over maintainership (ie. being one of the people able to merge commits, reply to issues, etc.) because he doesn't have the time for all that.
As far as I know Paul created his GitHub account only because I wanted to add him to the group.

As I said, if you manage to get further even a little bit, please consider creating a PR with your changes so other people (maybe me should I suddenly get motivated again) can continue your work.