This repository has been archived by the owner on Dec 28, 2017. It is now read-only.
don't crash when using a CNAME ALIAS with zone.record_sets #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when you try to print a record_set that is a CNAME ALIAS you will get: TypeError: __init__() got an unexpected keyword argument 'alias_hosted_zone_id'
gtaylor
added a commit
that referenced
this pull request
Apr 20, 2015
don't crash when using a CNAME ALIAS with zone.record_sets
|
Wonderful, thanks! Maybe you could open an issue to nag me to release this to PyPi before I forget :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve issue #8, i tested this with a CNAME ALIAS and also tried to use record_set.is_alias_record_set()
when you try to print a record_set that is a CNAME ALIAS you will get:
TypeError: init() got an unexpected keyword argument 'alias_hosted_zone_id'