This repository has been archived by the owner on Dec 28, 2017. It is now read-only.
Added support for health checks and improved tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to manage health checks (tested too). TODO: Write documentation about health checks.
|
Thanks for your thorough work on this! Could I talk you into updating the documentation in doc_src to show how to use these? |
|
My english is not the best, I'll try to do my best. On Tue, Feb 4, 2014 at 4:57 PM, Greg Taylor notifications@github.comwrote:
René Martín Rodríguez |
- Add parser to HealthCheckVersion & Update test to check it.
|
Going to close this for now since it's not mergeable just yet. Feel free to re-submit if you ever get the urge to work on it again. Thanks for your submission! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I've added support for managing Health Checks and some changes to tests to be able to run them without calling Amazon API.