Refactored schema to input types code

- removed unused function - created constant dictionary
gterrono · Aug 5, 2014 · 566208c · 566208c
1 parent 75213c9
commit 566208c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 30 deletions.
diff --git a/client/collection_view.coffee b/client/collection_view.coffee
@@ -1,13 +1,3 @@
-schemaToInputType = (type) ->
-  dict = {
-    number: 'number'
-    string: 'text'
-    boolean: 'checkbox'
-  }
-  if type of dict
-    dict[type]
-  else 'text'
-
 get_sort_by = ->
   sort_by = {}
   sort_by[Houston._session('sort_key')] = Houston._session('sort_order')
@@ -190,13 +180,5 @@ Template._houston_collection_view.events
 Template._houston_new_document_field.helpers
   field_is_id: -> @name is '_id'
   document_id: -> Houston._session('document_id')
-  has_type: ->
-    @type is 'string' ||
-      @type is 'number' ||
-      @type is 'checkbox'
-  input_type: ->
-    {
-    number: 'number'
-    string: 'text'
-    boolean: 'checkbox'
-    }[@type]
+  has_type: -> Houston._INPUT_TYPES[@type]?
+  input_type: -> Houston._INPUT_TYPES[@type]
diff --git a/client/document_view.coffee b/client/document_view.coffee
@@ -19,16 +19,8 @@ Template._houston_document_view.helpers
 Template._houston_document_field.helpers
   field_is_id: -> @name is '_id'
   document_id: -> Houston._session('document_id')
-  has_type: ->
-    @type is 'string' ||
-    @type is 'number' ||
-    @type is 'checkbox'
-  input_type: ->
-    {
-      number: 'number'
-      string: 'text'
-      boolean: 'checkbox'
-    }[@type]
+  has_type: -> Houston._INPUT_TYPES[@type]?
+  input_type: -> Houston._INPUT_TYPES[@type]
 
 get_collection = -> Houston._get_collection(Houston._session('collection_name'))
 

diff --git a/lib/shared.coffee b/lib/shared.coffee
@@ -37,3 +37,9 @@ Houston._get_fields = (documents) ->
 
 Houston._get_field_names = (documents) ->
   _.pluck(Houston._get_fields(documents), 'name')
+
+Houston._INPUT_TYPES = {
+  number: 'number'
+  string: 'text'
+  boolean: 'checkbox'
+}