Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove the actual stylesheet nodes when viewing houston #172

Closed
matteodem opened this issue May 11, 2014 · 4 comments
Closed

Don't remove the actual stylesheet nodes when viewing houston #172

matteodem opened this issue May 11, 2014 · 4 comments

Comments

@matteodem
Copy link
Contributor

@matteodem matteodem commented May 11, 2014

At the moment we remove all other stylesheets that are present to the current meteor app and when switching (without completely refreshing the app) sites, they'd have no styling applied anymore after viewing Houston.

I'd strongly suggest we don't do that anymore, since we also prevent people from overriding the admin styles and it's a hack.

@AlexeyMK
Copy link
Collaborator

@AlexeyMK AlexeyMK commented May 11, 2014

Happily - what do you think would be a better solution? The current one was
one of those "least-bad-idea" type things.

On Sun, May 11, 2014 at 11:02 AM, matteodem notifications@github.comwrote:

At the moment we remove all other stylesheets that are present to the
current meteor app and when switching (without completely refreshing the
app) sites, they'd have no styling applied anymore after viewing Houston.

I'd strongly suggest we don't do that anymore, since we also prevent
people from overriding the admin styles and it's a hack.


Reply to this email directly or view it on GitHubhttps://github.com//issues/172
.

@matteodem
Copy link
Contributor Author

@matteodem matteodem commented May 13, 2014

  • Not removing stylesheets at all (since the styles are prefixed with .houston, if I remember right)
  • Corrupting the stylesheet links and replacing them again after leaving the houston ui (also hacky)
@AlexeyMK
Copy link
Collaborator

@AlexeyMK AlexeyMK commented May 13, 2014

Cc @gterrono

I think the reason we remove user defined stylesheets is when they style
top-level things like "form" or "input" - in Houston's case, this is a bad
idea, but blaming the user is no great solution.

I think manually putting the stylesheets back in is probably a workable
idea - but so is (and maybe this is easier) patching ironrouter so that any
link to a non-houston resource requires a hard reload (using
window.location = ...)

Sounds like a fun (though somewhat hacky) thing to play with.
On May 12, 2014 11:58 PM, "matteodem" notifications@github.com wrote:

  • Not removing stylesheets at all (since the styles are prefixed with
    .houston, if I remember right)
  • Corrupting the stylesheet links and replacing them again after
    leaving the houston ui (also hacky)


Reply to this email directly or view it on GitHubhttps://github.com//issues/172#issuecomment-42923185
.

@gterrono
Copy link
Owner

@gterrono gterrono commented May 14, 2014

Yeah, we need to remove the css because it interferes with houston. I think the best option is to add all the stylesheets back when we go to a non houston page, although that's just adding a hacky solution onto a hacky solution.

@gterrono gterrono removed their assignment Jul 16, 2014
@gterrono gterrono closed this Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.