bug custom xfold xgb

gtesei · Mar 23, 2016 · 7b24cdf · 7b24cdf
1 parent a03b9c1
commit 7b24cdf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R-package/R/fastRegression.R b/R-package/R/fastRegression.R
@@ -1393,8 +1393,8 @@ ff.xgb.cv <- function(params=list(), data, nrounds, nfold, label = NULL, xgb.met
     if (length(early.stop)>1) early.stop = early.stop[length(early.stop)]
 
     ## stop?
-    if ( early.stop < (iter.num*nrounds+nrounds) || (!maximize && !is.null(perf.last) && min(dt[[lab]]) > perf.last) 
-         || (maximize && !is.null(perf.last) && max(dt[[lab]]) < perf.last) )  {
+    if ( early.stop < (iter.num*nrounds+nrounds) || (!maximize && !is.null(perf.last) && min(dt[[lab]]) >= perf.last) 
+         || (maximize && !is.null(perf.last) && max(dt[[lab]]) <= perf.last) )  {
 
       inCV = FALSE
 

diff --git a/fastfurious-manual.pdf b/fastfurious-manual.pdf