Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move color logic outside of libadwaita utils/colors into theme package #55

Closed
MalcolmMielle opened this issue Jan 29, 2022 · 5 comments
Closed

Move color logic outside of libadwaita utils/colors into theme package #55

MalcolmMielle opened this issue Jan 29, 2022 · 5 comments

Comments

@MalcolmMielle
Copy link
Collaborator

For now, the colors used for avatars are hardcoded in utils/colors.dart. The color logic should be delegated to the theme (e.g. yaru or adwaita) and moved out of libawaita.
@prateekmedia
Copy link
Member

Will yaru theme accept it?

@MalcolmMielle
Copy link
Collaborator Author

Maybe there is a way to do it. I'm not sure how.

@prateekmedia
Copy link
Member

I think they should be hardcoded as it is the same for the original libadwaita library:
https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/stylesheet/widgets/_avatar.scss

@prateekmedia
Copy link
Member

If you disagree, then I will reopen the issue. I am open for suggestions.

@MalcolmMielle
Copy link
Collaborator Author

Ok sounds good for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MalcolmMielle @prateekmedia