Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder pattern uses Vec<String> #1122

Closed
bilelmoussaoui opened this issue May 2, 2021 · 10 comments
Closed

Builder pattern uses Vec<String> #1122

bilelmoussaoui opened this issue May 2, 2021 · 10 comments

Comments

@bilelmoussaoui
Copy link
Member

The builder pattern uses Vec<String> instead of something a bit nicer to use like &[&str], it could even use T: AsRef<str>; &[T] & then take ownership of the strings inside the builder method.

@Rakielle
Copy link

Hi @bilelmoussaoui, I'm an Outreachy applicant and I'd like to be assigned this issue

@bilelmoussaoui
Copy link
Member Author

Hi @Rakielle, please go ahead :) let me know if you need help figuring this one out.

@Rakielle
Copy link

Thank you @bilelmoussaoui, I was having an issue joining the Matrix chat. I sent you a mail about it.
Could you please check?

@bilelmoussaoui
Copy link
Member Author

Oh sorry, I missed that one. I think you were trying to create an account on the GNOME matrix server which is only open to GNOME contributors/developers (that have a @gnome email address). You can create an account on the main matrix homeserver and join the room just fine

@Rakielle
Copy link

Rakielle commented Apr 13, 2022

Thanks @bilelmoussaoui, I've been able to join the room :)

@Rakielle
Copy link

@bilelmoussaoui I was using the gir book in the repository to learn how gir works but I got stuck at the Generate the FFI library tutorial. The tutorial uses the GtkSource-3.0.gir file which isn't present in the https://github.com/gtk-rs/gir-files repo. I tried using Gtk-3.0.gir file which did not work as I keep getting lots of errors.

@bilelmoussaoui
Copy link
Member Author

You can grab it from an older version of gir-files, like in https://github.com/gtk-rs/gir-files/tree/8a626fde7528ebb62a4d7902f201e483ca2ae05b

@Rakielle
Copy link

Rakielle commented Apr 19, 2022

@bilelmoussaoui Thank you for the link, I was able to extract the GtkSource-30.gir file from it. I'm till having issues generating an FFI library for the GtkSource-3.0.gir file though, I keep running into several errors.

Is there a recent documentation that could help me get setup? I'm currently using https://gtk-rs.org/gir/book/tutorial/sys_library.html

@Rakielle
Copy link

Hi @bilelmoussaoui, in what files can I find the builder patterns?

@bilelmoussaoui
Copy link
Member Author

This got fixed recently and we are using impl Into<glib::StrV>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants