Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Calls into object subclasses that are still floating can cause reference issues #545

Closed
sdroege opened this issue Dec 4, 2019 · 1 comment

Comments

@sdroege
Copy link
Member

sdroege commented Dec 4, 2019

For virtual methods we ensure that the object is still floating once the virtual method returns and not floating during the scope of the virtual method. However the same problem would happen if other callbacks with the floating object would happen, any kind of callback. The first use in the bindings in a transfer none context would sink the floating reference and cause memory leaks or worse.

Unclear how to handle this other than using the floating reference guard in all callbacks, signal handler trampolines, etc.

@sdroege
Copy link
Member Author

sdroege commented Dec 6, 2019

As this now actually causes crashes in practice and I have a plan that improves the situation at least, let's block the release on this too.

@sdroege sdroege mentioned this issue Dec 6, 2019
43 tasks
@sdroege sdroege closed this as completed Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant