Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind g_utf8 / g_unichar APIs #763

Closed
sdroege opened this issue Sep 5, 2022 · 3 comments · Fixed by #1146
Closed

Bind g_utf8 / g_unichar APIs #763

sdroege opened this issue Sep 5, 2022 · 3 comments · Fixed by #1146
Labels
enhancement New feature or request glib

Comments

@sdroege
Copy link
Member

sdroege commented Sep 5, 2022

std doesn't have almost anything of that, and the crate implementing all that seems is using icu, which is huge and annoying to build. The utf8 APIs should probably take &GStr / GString, otherwise we end up creating lots of copies.

@sdroege sdroege added enhancement New feature or request glib labels Sep 5, 2022
@bilelmoussaoui
Copy link
Member

Should this be closed now? cc @sdroege

@sdroege
Copy link
Member Author

sdroege commented Dec 12, 2022

There's still API missing, like g_utf8_next_char()

@RealKC
Copy link
Contributor

RealKC commented Dec 13, 2022

When binding the g_utf8 APIs I didn't include the ones that I thought were already offered by the rust stdlib through str (which GStr gets through its Deref<Target = &str> impl), IIRC that was one of them.

However, the g_unichar APIs are still missing (some of them are offered by the stdlib already, but not all), so this issue should stay open for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request glib
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants