This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
glib: Remove glib::TypedValue #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
reviewed
Apr 11, 2021
It's not very useful in practice and there seems to be no usage of it. If a "typed value" is needed then the proper Rust type can be used as well and there's no reason to keep it in a GValue wrapper.
sdroege
force-pushed
the
remove-typed-value
branch
from
b9bb768
to
f051a1c
Compare
bilelmoussaoui
approved these changes
Apr 11, 2021
gstreamer-github
pushed a commit
to sdroege/gstreamer-rs
that referenced
this pull request
Apr 12, 2021
See gtk-rs/gtk3-rs#449. This struct remains vital in GStreamer code to tie a type to an (untyped) SendValue, so that the underlying value can be retrieved without having to guess its type. That type is anyway stored in a private member T::TagType. Co-authored-by: Marijn Suijten <marijns95@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not very useful in practice and there seems to be no usage of it.
If a "typed value" is needed then the proper Rust type can be used as
well and there's no reason to keep it in a GValue wrapper.
Extracted from #31 for easier reviewing and smaller PRs.