Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it worth to mention necessity to add load_css() in main.rs in the book at "Set CSS Name and Use Exported Colors" section of 14th (CSS) chapter? #1335

Closed
zekefast opened this issue Mar 17, 2023 · 4 comments · Fixed by #1339
Labels

Comments

@zekefast
Copy link
Contributor

zekefast commented Mar 17, 2023

Text body of "Set CSS Name and Use Exported Colors" section of 14th (CSS) chapter does not mention about necessity to add load_css() in main.rs.

Actual code listing contains necessary call but it seems to me it worth to mention that addition in order to remind the reader about necessity to load CSS styles.

WDYT @Hofer-Julian ?

P.S. It probably worth to mention inclusion of style.css into resources.gresource.xml file.

@Hofer-Julian
Copy link
Collaborator

Text body of "Set CSS Name and Use Exported Colors" section of 14th (CSS) chapter does not mention about necessity to add load_css() in main.rs.

Actual code listing contains necessary call but it seems to me it worth to mention that addition in order to remind the reader about necessity to load CSS styles.

WDYT @Hofer-Julian ?

I am not sure I understand the suggestion. That you need to load css in the startup callback is mentioned. Are you suggesting once isn't enough?

@zekefast
Copy link
Contributor Author

Are you suggesting once isn't enough?

Yeah. Reader probably will use code from chapter 13 or copy it over and at the end of 14th chapter it could forget about CSS loading piece. At least that's what I did :) So, it seems reasonable to put one sentence as a reminder about load_css() and resources.gresource.xml.

@Hofer-Julian
Copy link
Collaborator

Fair enough!
Do you want to open a PR? :)

@zekefast
Copy link
Contributor Author

Okay. I'll done with some family staff in the morning and then I'll prepare one closer to my evening (CET).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants