Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom validators to use formatMessage #17

Closed
wants to merge 2 commits into from
Closed

Allow custom validators to use formatMessage #17

wants to merge 2 commits into from

Conversation

nealoke
Copy link

@nealoke nealoke commented Nov 8, 2017 •
edited
Loading

See #16

Basically allow custom validators added by addValidator to use Validators.formatMessage when the custom validator returns an object.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2c0bbc5 on nealoke:patch-2 into f453258 on gtournie:master.

@gtournie
Copy link
Owner

gtournie commented Nov 8, 2017 •
edited
Loading

@nealoke There was an issue here, indeed. addValidator wasn't using formatMessage when it was returning an object. I fixed it in 2.1.1.

If you submit a PR, please make sure the tests are still passing :)

@gtournie gtournie closed this Nov 8, 2017
@nealoke nealoke mentioned this pull request Nov 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nealoke @coveralls @gtournie