-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Adding optional IDs as part of mutation API #1261
Comments
Based on the discussion in slack, the So it would have to be:
similar for the other tries (source and vulnerability) |
I will work on getting this completed to move forward with a more stable API for future releases |
Based on discussions with @jeffmendoza and thinking about this more, we would need to have some sort of union between the |
Based on discussion and experimentation, a union type cannot be created but a new inputType can be created similar to:
where the mutations would change to:
in this case, either the ID or the Similar considerations would have to be done for the other nouns. |
closed via #1708 |
From the discussion in slack around #594 , we discussed what the interface should be in creating links between multiple evidence tree nodes.
This brought up the question of how node inputs are done today, for example in IsDependency, PkgInputSpec is used to determine which pkg and depPkg to link.
This is usually implemented in the backend through making a look up to the node, and getting its ID to form the edge. Lookups during ingestion generally slow down the process (e.g. thus introducing the guacKey).
This proposal is to add an optional ID to each InputSpec so that, if provided the backend can use it to enable quick retrieval of the nodes that it needs to form edges around.
Would use the IDs provided in
pkg
anddepPkg
in:The text was updated successfully, but these errors were encountered: