Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic metadata gql #1002

Merged
merged 2 commits into from Jul 5, 2023
Merged

add generic metadata gql #1002

merged 2 commits into from Jul 5, 2023

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Jun 30, 2023 •
edited

Description of the PR

Part 1 of #975

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@lumjjb
add generic metadata gql
f1da81d 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb marked this pull request as ready for review June 30, 2023 18:01
@lumjjb
added timestamp to metadata
8742728 
Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@kodiakhq kodiakhq bot merged commit 25a5c72 into main Jul 5, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the generic-metadata branch July 5, 2023 15:10
@lumjjb lumjjb mentioned this pull request Jul 5, 2023
Closed
6 tasks
rmetzman pushed a commit to rmetzman/guac that referenced this pull request Jul 5, 2023
@lumjjb
add generic metadata gql (guacsec#1002)
8daad5c 
* add generic metadata gql

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

* added timestamp to metadata

Signed-off-by: Brandon Lum <lumjjb@gmail.com>

---------

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb mentioned this pull request Jul 5, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lumjjb @mihaimaruseac @pxp928