Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup arango backend and add source ingestion and query for arango #1034

Merged
merged 9 commits into from Jul 10, 2023
Merged

Cleanup arango backend and add source ingestion and query for arango #1034

merged 9 commits into from Jul 10, 2023

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jul 10, 2023

Description of the PR

Cleanup arango backend and add source ingestion and query for arango

  • rename collections to more appropriate names
  • change query variables to match for packages
  • add source ingestion and query
  • update search to include source

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
add inital src
f89f7dc 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update package collection names
6df9097 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add src root and src types
e8247f5 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add ingest src
733a8df 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update search to include source
facc3d3 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add ingestSources to graphql
0f4fe78 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 requested a review from lumjjb July 10, 2023 13:25
@pxp928
fix bug in ingestIsOccurrences
2c5052e 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
revert bulk assembler change
a1a0cf6 
Signed-off-by: pxp928 <parth.psu@gmail.com>
lumjjb
lumjjb approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, LGTM!

pkg/assembler/backends/neo4j/src.go Outdated Show resolved Hide resolved
@pxp928
change for panic to error for neo4j backend
eb4de97 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@kodiakhq kodiakhq bot merged commit 37971bd into guacsec:main Jul 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxp928 @mihaimaruseac @lumjjb